Skip to content

kvserver: remove remaining RACv1 code #147515

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 31, 2025
Merged

Conversation

sumeerbhola
Copy link
Collaborator

Informs #136529

Epic: none

Release note: None

@sumeerbhola sumeerbhola requested review from pav-kv and kvoli May 30, 2025 02:47
@sumeerbhola sumeerbhola requested review from a team as code owners May 30, 2025 02:47
Copy link

blathers-crl bot commented May 30, 2025

Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks.

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@sumeerbhola
Copy link
Collaborator Author

First commit is from #147500

Copy link
Contributor

@kvoli kvoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 19 of 19 files at r1, 60 of 60 files at r4, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @pav-kv)

@sumeerbhola
Copy link
Collaborator Author

Rebased

TFTR!

@sumeerbhola
Copy link
Collaborator Author

TestDockerCLI_test_demo_global_insecure/test_demo_global_insecure.tcl/runMode=docker flaked

@sumeerbhola
Copy link
Collaborator Author

bors r=kvoli

craig bot pushed a commit that referenced this pull request May 30, 2025
147515: kvserver: remove remaining RACv1 code r=kvoli a=sumeerbhola

Informs #136529

Epic: none

Release note: None

Co-authored-by: sumeerbhola <[email protected]>
@craig
Copy link
Contributor

craig bot commented May 30, 2025

Build failed:

Informs cockroachdb#136529

Epic: none

Release note: None
@sumeerbhola
Copy link
Collaborator Author

bors r=kvoli

@craig
Copy link
Contributor

craig bot commented May 31, 2025

@craig craig bot merged commit d1b279d into cockroachdb:master May 31, 2025
22 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants