Skip to content

fix: overscroll behaviour for code blocks #251

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: overscroll behaviour for code blocks #251

wants to merge 1 commit into from

Conversation

MarkusWendorf
Copy link

I found an issue with code blocks that block the user from scrolling the whole page, because overflow: auto catches the scroll and does not propagate it to the document.

Repro for the issue: https://github.com/MarkusWendorf/codehike-overscroll

  • npm i
  • npm run dev
  • goto http://localhost:3000/posts/react/components
  • place cursor inside the second code block and try to scroll the document
  • it does not scroll unless adding overscroll-behaviour: "auto" to ch-code-scroll-parent

This PR fixes that behaviour by adding overscroll-behaviour: "auto" to ch-code-scroll-parent.

@vercel
Copy link

vercel bot commented Jul 30, 2022

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
chtest ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 1:09PM (UTC)
playground ✅ Ready (Inspect) Visit Preview Jul 30, 2022 at 1:09PM (UTC)

@vercel vercel bot temporarily deployed to Preview – playground July 30, 2022 13:08 Inactive
@vercel vercel bot temporarily deployed to Preview – chtest July 30, 2022 13:09 Inactive
@pomber
Copy link
Contributor

pomber commented Jul 30, 2022

Thanks for looking into it. Have you tried the latest version? I think I fixed this with #241

@MarkusWendorf
Copy link
Author

Yes v0.7.3-next.2 does the trick. Closed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants