This repository was archived by the owner on Feb 25, 2025. It is now read-only.
Added min max limits to RadialTimePickers #272
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks ok to me, I'm merging it, thank you for your contribution @AustrianDudes ! I will translate the news keys to french after merge, we will need contributions for other major languages though. |
CedricGatay
added a commit
that referenced
this pull request
Apr 22, 2016
French strings for PR #272 : allowing user to set time limits
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In case you need it at some point; I made a small modification for the RadialTimePicker. It is now possible to internally set a given date context (setPickerDate) for the time picker e.g. yesterday. This can be used to validate the selected time against a date (setValidateDateTime) and a defined range in minutes (setFutureMinutesLimit and setPastMinutesLimit).
e.g.
setPickerDate -> 20.04.2016
setValidateDateTime -> 21.04.2016 12:00
setFutureMinutesLimit -> 1440
setPastMinutesLimit -> 1440
If the time 13:00 is selected everything proceeds as usual.
If the time 11:00 is selected a warning is issued that the selected time is too far in the past.