Skip to content

Use gitoxide for Git config #10

Open
@paulyoung

Description

@paulyoung

It would be preferable to use gitoxide's Git config implementation as it's surely more robust than what's currently in place. That should be considered as ad-hoc and a temporary workaround.

// TODO: figure out why this doesn't find the setting when used with `git -c`
// let private_key_path = config.string("icp.privateKey").ok_or_else(|| {
// anyhow!("failed to read icp.privateKey from git config. Set with `git config --global icp.privateKey <path to private key>`")
// })?;

@Byron – do you have any suggestions here? This isn't urgent but it would be a nice change (see below)

Once the custom config options we require in the icp namespace are confirmed as working using gitoxide (if possible) we should investigate if git -c http.proxy=http://localhost:9091 -c http.sslCAinfo=~/.proxyman/proxyman-ca.pem <command> then "just works" or if supporting that requires further changes.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions