Skip to content

Handle flags of Regex expression for cucumber #3214

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

anils92
Copy link
Contributor

@anils92 anils92 commented Jan 25, 2022

Motivation/Description of the PR

Current Issue

If you create a step definition like Given(/^I am on "([^"]+)" page$/i, openPageStep); and use Given I am on "Login" page, you will get error stating # No steps matching "I am on "Login" page" but It will work for Given(/^I am on "([^"]+)" page$/, openPageStep);

Type of change

  • 🔥 Breaking changes
  • 🚀 New functionality
  • 🐛 Bug fix
  • 📋 Documentation changes/updates
  • ♨️ Hot fix
  • 🔨 Markdown files fix - not related to source code
  • 💅 Polish code

Checklist:

  • Tests have been added
  • Documentation has been added (Run npm run docs)
  • Lint checking (Run npm run lint)
  • Local tests are passed (Run npm test)

Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DavertMik
Copy link
Contributor

Thanks!

@DavertMik DavertMik merged commit a6e41cf into codeceptjs:3.x Jan 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

flags are not supported in Regex for cucumber steps
4 participants