Skip to content

No fluent setter for usingDefaultExcludes in AbstractFileSet #311

Closed
@redzi

Description

@redzi

This is not an issue but a proposal for a very minor change that would make the creation of FileSets easier.
There is no fluent way of setting the usingDefaultExcludes flag in AbstractFileSet.

Due to this inconvenience instead of a completely fluent way of creating a FileSet instance:

fileSet(new File("foo"))
          .prefixed("pfx")
          .include(includes)
          .exclude(exc)
          .usingDefaultExcludes(usingDefaultExcludes);

one needs to do it like this:

DefaultFileSet fileSet = fileSet(new File("foo"))
          .prefixed("pfx")
          .include(includes)
          .exclude(exc);

fileSet.setUsingDefaultExcludes(false);

The fileSet variable needs to be of type DefaultFileSet because the FileSet interface does not provide the setter.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions