Skip to content

Make it work also on JDK9 with new versioning scheme #12

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 11, 2015

Conversation

ctomc
Copy link
Contributor

@ctomc ctomc commented Dec 10, 2015

JDK9 comes with new versioning scheme that is defined in http://openjdk.java.net/jeps/223

This patch fixes the AbstractZipArchiver to work on JDK9 as well as older versions properly.

krosenvold added a commit that referenced this pull request Dec 11, 2015
Make it work also on JDK9 with new versioning scheme
@krosenvold krosenvold merged commit 61dfeb2 into codehaus-plexus:master Dec 11, 2015
@Sanne
Copy link

Sanne commented Dec 11, 2015

Thanks for the quick merge @krosenvold !
Should I close issue #13 ? Sorry not familiar with the process.

I now opened this one as a follow up:

Would you be able to suggest if I need to open a bug on Maven too to then have that upgrade the plugins version?

@krosenvold
Copy link
Member

I have a very short list of other issues to fix in plexus-archiver before making a release, shouldn't be too long. The update of default plugins normally happens when the jar plugin has been "in the wild" for a little time, you really dont need to create an issue for that

@Sanne
Copy link

Sanne commented Dec 11, 2015

thanks, good to know!

@krosenvold
Copy link
Member

I'm sure you're aware of this, but just for the record: The moment plexus-archiver is released, it's trivial to do an upgrade of your local poms as described here:
http://blog.sonatype.com/2008/04/how-to-override-a-plugins-dependency-in-maven/#.VmrHQBrhBZo

@Sanne
Copy link

Sanne commented Dec 11, 2015

Yes, we're doing something like that ;)
But still would be nice to have a simpler way for the "masses". Probably not many testing Java 9 yet via Maven, but I hope it will become a good practice soon.

@krosenvold
Copy link
Member

You're talking to a guy who deployed a production system with Java8 7 months before it was released :)

We're still relatively early in the JDK9 cycle, so I think it's fairly normal to expect a certain amount of kludges still (I mean, JDK9 is still not even feature complete!) At this point we'd normally prioritize getting the underlying libraries up to speed (like plexus-archiver) and release these, because then we can update all the higher level requirements. Normally they get released for other reasons fairly soon anyway.

@Sanne
Copy link

Sanne commented Jan 20, 2016

Hi @krosenvold , I see new Maven releases were published but the fix was not incorporated yet.
Could you please release an update and let the Maven team know?

I was notified today of several other people hitting this, and I see above testng and junit referencing this issue too.

@ctomc
Copy link
Contributor Author

ctomc commented Jan 20, 2016

Just FYI, another workaround is to use much older version of plexus-archiver, 2.4.4 is the last one that doesn't have broken check in it.
But that is not always solution as some plugins are not compatible with older version.
our "hack" ctomc/wildfly-core@9636823

@plamentotev plamentotev mentioned this pull request Apr 13, 2016
karussell referenced this pull request in ctomc/wildfly-core Apr 13, 2016
- use different assembly plugin
julianhyde added a commit to julianhyde/calcite that referenced this pull request May 27, 2016
Tried to upgrade plexus-archiver to get fix for
codehaus-plexus/plexus-archiver#12
but maven doesn't seem to be seeing it yet.
julianhyde added a commit to julianhyde/calcite that referenced this pull request Jun 17, 2016
Tried to upgrade plexus-archiver to get fix for
codehaus-plexus/plexus-archiver#12
but maven doesn't seem to be seeing it yet.
gsmet added a commit to gsmet/hibernate-validator that referenced this pull request Oct 11, 2016
The maven-assembly-plugin uses a version which does not support JDK9.

See codehaus-plexus/plexus-archiver#12
gunnarmorling pushed a commit to hibernate/hibernate-validator that referenced this pull request Oct 12, 2016
The maven-assembly-plugin uses a version which does not support JDK9.

See codehaus-plexus/plexus-archiver#12
gsmet added a commit to hibernate/hibernate-validator that referenced this pull request Oct 14, 2016
The maven-assembly-plugin uses a version which does not support JDK9.

See codehaus-plexus/plexus-archiver#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants