-
Notifications
You must be signed in to change notification settings - Fork 49
Make it work also on JDK9 with new versioning scheme #12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Make it work also on JDK9 with new versioning scheme
Thanks for the quick merge @krosenvold ! I now opened this one as a follow up: Would you be able to suggest if I need to open a bug on Maven too to then have that upgrade the plugins version? |
I have a very short list of other issues to fix in plexus-archiver before making a release, shouldn't be too long. The update of default plugins normally happens when the jar plugin has been "in the wild" for a little time, you really dont need to create an issue for that |
thanks, good to know! |
I'm sure you're aware of this, but just for the record: The moment plexus-archiver is released, it's trivial to do an upgrade of your local poms as described here: |
Yes, we're doing something like that ;) |
You're talking to a guy who deployed a production system with Java8 7 months before it was released :) We're still relatively early in the JDK9 cycle, so I think it's fairly normal to expect a certain amount of kludges still (I mean, JDK9 is still not even feature complete!) At this point we'd normally prioritize getting the underlying libraries up to speed (like plexus-archiver) and release these, because then we can update all the higher level requirements. Normally they get released for other reasons fairly soon anyway. |
Hi @krosenvold , I see new Maven releases were published but the fix was not incorporated yet. I was notified today of several other people hitting this, and I see above testng and junit referencing this issue too. |
Just FYI, another workaround is to use much older version of plexus-archiver, 2.4.4 is the last one that doesn't have broken check in it. |
- use different assembly plugin
Tried to upgrade plexus-archiver to get fix for codehaus-plexus/plexus-archiver#12 but maven doesn't seem to be seeing it yet.
Tried to upgrade plexus-archiver to get fix for codehaus-plexus/plexus-archiver#12 but maven doesn't seem to be seeing it yet.
The maven-assembly-plugin uses a version which does not support JDK9. See codehaus-plexus/plexus-archiver#12
The maven-assembly-plugin uses a version which does not support JDK9. See codehaus-plexus/plexus-archiver#12
The maven-assembly-plugin uses a version which does not support JDK9. See codehaus-plexus/plexus-archiver#12
JDK9 comes with new versioning scheme that is defined in http://openjdk.java.net/jeps/223
This patch fixes the AbstractZipArchiver to work on JDK9 as well as older versions properly.