[Bug]: Update popup notification although --disable-update-check

[reaseno]

Is there an existing issue for this?

• I have searched the existing issues

OS/Web Information

• Web Browser: Vivaldi
• Local OS: Win10
• Remote OS: Debian
• Remote Architecture:
• code-server --version: 4.0.1

Steps to Reproduce

1. run with: code-server --disable-update-check

Expected

No update check and notification.

Actual

Update check and a popup notification for code-server 4.0.2 within the IDE at the bottom right.

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

• I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

• I am using HTTPS.

Notes

No response

[jsjoeio]

This is not something we support unfortunately (running code-server --help shows you the flags we support).

You should be able to disable updates in your VS Code Settings by setting it to "none"

[reaseno]

I get this parameter with "code-server --help":

--disable-update-check Disable update check. Without this flag, code-server checks every 6 hours against the latest github release and then notifies you once every week that a new release is available.

And update-mode was set to none.

[jsjoeio]

My apologies...I didn't realize we still had that.

This flag is before my time. Did it used to work? Do you know what it should do?

I took a look through the codebase and I can't find any logic related to it 🤔 My thinking would be that it would set update-mode to none, but maybe it's supposed to do something else.

[reaseno]

All I know is that I get an update notification even though both options are set. So one of them doesn't seem to work anymore 🤷‍♂️

[jsjoeio]

Well that surely is annoying, isn't it? Sorry about that!

Maybe we lost some of that logic in 4.0.

@code-asher any ideas on how this worked previously?

[code-asher]

It would appear this got left out in the rebase.