Skip to content

[Bug]: Use npm instead of yarn in postinstall script #5056

Closed
@code-asher

Description

@code-asher

Is there an existing issue for this?

  • I have searched the existing issues

OS/Web Information

  • Web Browser: n/a
  • Local OS: n/a
  • Remote OS: n/a
  • Remote Architecture: n/a
  • code-server --version: development

Steps to Reproduce

  1. yarn build release
  2. Uninstall yarn
  3. cd release && npm install

Expected

Install completes successfully.

Actual

Although I have not actually done this (uninstalling yarn is a pain), the postinstall script uses yarn so it will probably error that yarn cannot be found.

Logs

No response

Screenshot/Video

No response

Does this issue happen in VS Code?

  • I cannot reproduce this in VS Code.

Are you accessing code-server over HTTPS?

  • I am using HTTPS.

Notes

To fix:

  1. Replace yarn with npm in npm-postinstall.sh
  2. Generate shrinkwrap files for:
    1. lib/vscode/package.json
    2. lib/vscode/extensions/package.json

Metadata

Metadata

Assignees

No one assigned

    Labels

    bugSomething isn't workingtriageThis issue needs to be triaged by a maintainer

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions