[Feat]: Support --wait param

[amosyuen]

What is your suggestion?

Support --wait flag in the integrated terminal.

Why do you want this feature?

I like to use VSCode as the editor in git, the normal vscode supports code --wait, but code-server does not. --wait is needed to make sure the command line does not return until the file is closed in vscode.

Are there any workarounds to get this functionality today?

Not that I know of. https://github.com/coder/code-server/blob/1484bee621717ca49a50b1ed69184b66712497f0/CHANGELOG.md#changed-7 seems to indicate that it should work. But I have code version 4.8.3 and calling code --wait gives me error err Unknown option --wait

Are you interested in submitting a PR for this?

Probably not

[jsjoeio]

Hmm I couldn't get this to work either but I swear it used it.

~/dev/coder/code-server jsjoeio/wip-fix
❯ git config core.editor "code-server --wait ."
Alias tip: g config core.editor "code-server --wait ."

~/dev/coder/code-server jsjoeio/wip-fix*
❯ ga ci

~/dev/coder/code-server jsjoeio/wip-fix*
❯ gc
hint: Waiting for your editor to close the file... [2022-12-13T17:00:31.729Z] error Unknown option --wait
error: There was a problem with the editor 'code-server --wait .'.
Please supply the message using either -m or -F option.

~/dev/coder/code-server jsjoeio/wip-fix*

@code-asher any ideas?

[code-asher]

Is this inside the integrated terminal? It only works in the integrated terminal at the moment.

[jsjoeio]

Yes it is!

[code-asher]

Weird! Definitely need to investigate.

[sounddrill31]

Bumping this issue, as VSCode's web window is a lot nicer than nano or vi for git rebasing 😅