Skip to content

Integrate Coder Cloud Agent #2086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 29 commits into from
Oct 9, 2020
Merged

Integrate Coder Cloud Agent #2086

merged 29 commits into from
Oct 9, 2020

Conversation

nhooyr
Copy link
Contributor

@nhooyr nhooyr commented Sep 11, 2020

Will allow users the following flow:

  1. Install code-server.
  2. Run code-server.
  3. Run code-server --expose my-name.
  4. Authenticate with GitHub and then access their code-server instance over HTTPS at https://<github-user>-<instance-name>.cdr.dev.

Still a WIP and things above may change. We also need to open source the Go agent.

Sort of an alternative to Microsoft's Self Hosted Azure Codespaces. See #2077

@geiseri
Copy link
Contributor

geiseri commented Sep 13, 2020

It would be interesting to see this on gitlab too. Might be a better value, than competing against github.

@sr229
Copy link
Contributor

sr229 commented Sep 15, 2020

This might be prone to name collisions as there might be cases you'll want to run it on a seperate system should they choose not to use a container - we should add at least a randomized identifier which is how Codespaces has done it.

@nhooyr
Copy link
Contributor Author

nhooyr commented Oct 6, 2020

This might be prone to name collisions as there might be cases you'll want to run it on a seperate system should they choose not to use a container - we should add at least a randomized identifier which is how Codespaces has done it.

You get to pick the name every time. We'd rather have a short URL. If there is a conflict, we can append some random text to the name ourselves @sreya

@sreya
Copy link
Collaborator

sreya commented Oct 6, 2020

As @nhooyr said you get to pick the name everytime you register a new server, the names won't conflict across different users because it is a unique key composed of the server name and your github username. For now as a user, you cannot register two servers with the same name.

@nhooyr
Copy link
Contributor Author

nhooyr commented Oct 7, 2020

It would be interesting to see this on gitlab too. Might be a better value, than competing against github.

We only use GitHub for auth, we can add multiple options down the line.

@nhooyr nhooyr marked this pull request as ready for review October 7, 2020 18:11
@nhooyr nhooyr requested a review from code-asher as a code owner October 7, 2020 18:11
@nhooyr nhooyr requested a review from sreya October 7, 2020 18:11
nhooyr added 5 commits October 7, 2020 17:40
No purpose when all the args are in the args parameter.

We only need configArgs for bindAddrFromAllSources.
@nhooyr
Copy link
Contributor Author

nhooyr commented Oct 9, 2020

Made it clear --coder-bind is in beta and it's not shown by default in help output unless CS_BETA is non empty in the environment.

@nhooyr nhooyr merged commit daa1c86 into coder:master Oct 9, 2020
@nhooyr nhooyr deleted the master branch October 9, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants