-
Notifications
You must be signed in to change notification settings - Fork 6k
Add variables to better customize plugin directories #2147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Default plugin dir should actually use XDG I think. Thoughts? Having it inside code-server is weird, except maybe for built-in plugins. So maybe we should load both. |
74022fc
to
f9d3d10
Compare
I went ahead and did that. |
f9d3d10
to
7a98255
Compare
Should note this isn't backwards compatible with the previous method so maybe it would be better to maintain the old |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we use CS_PLUGIN_PATH
instead?
Where plugin path consists of colon separated directories in which plugins are loaded from.
And defaults to: $HOME/.config/code-server/plugins:/etc/code-server/plugins
.
Only one was colon separated but now they both are.
|
plugins
directory as beforePLUGIN_DIR
will set that directory instead of being used to specify an individual pluginPLUGIN_DIRS
can be used to set multiple individual plugins if you don't want to move them into a single directoryLemme know if we wanna change this up, this is just based off the VS Code plugin structure (except they use command line flags and not environment variables).
Closes #2122.