Skip to content

chore(deps): move yarn to devDependencies #3231

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Conversation

kylecarbs
Copy link
Member

Fixes yarn being shipped in our releases removing about ~5mb from the decompressed tar.

@kylecarbs kylecarbs requested a review from jsjoeio April 27, 2021 03:01
@kylecarbs kylecarbs requested a review from a team as a code owner April 27, 2021 03:01
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😍

@codecov
Copy link

codecov bot commented Apr 27, 2021

Codecov Report

Merging #3231 (04d3d3a) into main (07d6823) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3231   +/-   ##
=======================================
  Coverage   46.90%   46.90%           
=======================================
  Files          23       23           
  Lines        1196     1196           
  Branches      237      237           
=======================================
  Hits          561      561           
  Misses        451      451           
  Partials      184      184           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07d6823...04d3d3a. Read the comment docs.

@jsjoeio jsjoeio added the dependencies Pull requests that update a dependency file label Apr 27, 2021
@jsjoeio jsjoeio added this to the v3.9.4 milestone Apr 27, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Apr 27, 2021

Sweet! Feel free to merge! 🎉

@code-asher
Copy link
Member

I think this might make npm -i code-server not work. We could edit the docs to say yarn is required? Or add yarn in the post install script, maybe.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Address code-asher's comment

@kylecarbs
Copy link
Member Author

If it's needed for prod I guess it doesn't really make sense to remove right now... maybe a low-prio later thing.

@kylecarbs kylecarbs closed this Apr 30, 2021
@kylecarbs kylecarbs deleted the kylecarbs/yarn branch April 30, 2021 16:23
@jsjoeio jsjoeio added the chore Related to maintenance or clean up label May 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants