Skip to content

fix: placeholder password in hashed password example #3602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

patrickcylai
Copy link
Contributor

This PR fixes a minor mistake with the new hashed password section in docs, changes made to align the example with the correct placeholder text.

Checklist

  • updated CHANGELOG.md

@patrickcylai patrickcylai requested a review from a team as a code owner June 12, 2021 15:00
@patrickcylai patrickcylai force-pushed the patrickcylai/fix-docs-hashed-password branch from 1a27a3a to 5fae520 Compare June 12, 2021 15:25
@jsjoeio jsjoeio self-assigned this Jun 15, 2021
@jsjoeio jsjoeio added the docs Documentation related label Jun 15, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jun 15, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wow! Nice catch. Thanks for fixing that.

P.S. no need to update the CHANGELOG unless you want us to mention/credit you in the next release notes (we copy paste from CHANGELOG)

@codecov
Copy link

codecov bot commented Jun 15, 2021

Codecov Report

Merging #3602 (5fae520) into main (4bb7a8d) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3602   +/-   ##
=======================================
  Coverage   60.67%   60.67%           
=======================================
  Files          35       35           
  Lines        1790     1790           
  Branches      404      404           
=======================================
  Hits         1086     1086           
  Misses        562      562           
  Partials      142      142           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4bb7a8d...5fae520. Read the comment docs.

@patrickcylai
Copy link
Contributor Author

Thanks for the review Joe! Yeah I wasn’t about the checklist for Changelog, so I left it in there, in this case no changes needed there 😄 Feel free to merge.

@jsjoeio jsjoeio merged commit ddbff58 into coder:main Jun 16, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Jun 16, 2021

Woot woot! Thanks again @patrickcylai 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants