Skip to content

docs(guide): add note about configuration for NGINX #3726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 8, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 6, 2021

This adds a short note to the NGINX section of guide.md for how to configure the green section displayed in code-server's UI.

Screenshot

nginx

Fixes #3513

(thank you to @sestegra and @nakkaya for pointing this out!)

@jsjoeio jsjoeio added this to the 3.11.0 milestone Jul 6, 2021
@jsjoeio jsjoeio added the docs Documentation related label Jul 6, 2021
@jsjoeio jsjoeio self-assigned this Jul 6, 2021
@codecov
Copy link

codecov bot commented Jul 6, 2021

Codecov Report

Merging #3726 (48baad3) into main (102f811) will not change coverage.
The diff coverage is n/a.

❗ Current head 48baad3 differs from pull request most recent head 2540b0d. Consider uploading reports for the commit 2540b0d to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3726   +/-   ##
=======================================
  Coverage   61.55%   61.55%           
=======================================
  Files          35       35           
  Lines        1813     1813           
  Branches      365      365           
=======================================
  Hits         1116     1116           
  Misses        588      588           
  Partials      109      109           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 102f811...2540b0d. Read the comment docs.

@jsjoeio jsjoeio marked this pull request as ready for review July 6, 2021 19:53
@jsjoeio jsjoeio requested a review from a team as a code owner July 6, 2021 19:53
@jsjoeio jsjoeio force-pushed the jsjoeio-docs-nginx branch from 48baad3 to 2540b0d Compare July 6, 2021 19:54
@jsjoeio jsjoeio requested review from kylecarbs and removed request for kylecarbs July 6, 2021 19:54
@jsjoeio jsjoeio removed this from the 3.11.0 milestone Jul 6, 2021
Copy link
Contributor

@jawnsy jawnsy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@jsjoeio jsjoeio merged commit 8e75d32 into main Jul 8, 2021
@jsjoeio jsjoeio deleted the jsjoeio-docs-nginx branch July 8, 2021 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add documentation to configure the contents of the green section in the bottom left
2 participants