Skip to content

refactor: clean up testing files #3769

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 13, 2021
Merged

refactor: clean up testing files #3769

merged 1 commit into from
Jul 13, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Jul 12, 2021

I accidentally merged a PR that didn't have a file formatted correctly and it made CI on main fail. This fixes that but also clean ups some testing files to be better organized.

@jsjoeio jsjoeio requested a review from a team as a code owner July 12, 2021 23:55
@jsjoeio jsjoeio self-assigned this Jul 12, 2021
@jawnsy
Copy link
Contributor

jawnsy commented Jul 12, 2021

Ah, just curious, shouldn't the same formatting checks run on PRs and main? How'd it get merged in the first place?

@jsjoeio jsjoeio added chore Related to maintenance or clean up testing Anything related to testing labels Jul 12, 2021
@jsjoeio jsjoeio added this to the 3.11.0 milestone Jul 12, 2021
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 12, 2021

I hit enable auto-merge which says "Automatically merge when all requirements are met." - let me checking the repo settings

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 12, 2021

image

Weird, pre-build is not required, but should be? Enabling now: cc @oxy and @code-asher

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 12, 2021

actually, i bet i broke it when i changed it to "Pre-Build" instead of "Pre-build"

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 12, 2021

argh, auto update imports didn't work lol fixing

@jawnsy
Copy link
Contributor

jawnsy commented Jul 13, 2021

Haha, I dislike auto merge because of these sorts of problems, but I see how it can be helpful 🤷‍♂️

@jsjoeio jsjoeio force-pushed the jsjoeio-chore-cleanup branch from ac8790a to fc16f7e Compare July 13, 2021 00:05
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 13, 2021

I feel ya, luckily this has only happened once or twice

@jsjoeio jsjoeio enabled auto-merge July 13, 2021 00:07
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 13, 2021

Moment of truth

@codecov
Copy link

codecov bot commented Jul 13, 2021

Codecov Report

Merging #3769 (0f03802) into main (002fa08) will increase coverage by 1.33%.
The diff coverage is 100.00%.

❗ Current head 0f03802 differs from pull request most recent head fc16f7e. Consider uploading reports for the commit fc16f7e to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3769      +/-   ##
==========================================
+ Coverage   61.55%   62.89%   +1.33%     
==========================================
  Files          35       35              
  Lines        1813     1838      +25     
  Branches      365      371       +6     
==========================================
+ Hits         1116     1156      +40     
+ Misses        588      577      -11     
+ Partials      109      105       -4     
Impacted Files Coverage Δ
src/browser/pages/vscode.ts 76.36% <100.00%> (+15.75%) ⬆️
src/node/util.ts 80.20% <100.00%> (+8.03%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a5cf018...fc16f7e. Read the comment docs.

@jsjoeio jsjoeio merged commit 723a274 into main Jul 13, 2021
@jsjoeio jsjoeio deleted the jsjoeio-chore-cleanup branch July 13, 2021 00:19
@code-asher
Copy link
Member

code-asher commented Jul 13, 2021

Hmm but we require both build and end-to-end tests which require pre-build? Is it sneaking in the auto-merge in the gaps before the next check starts??

@jsjoeio
Copy link
Contributor Author

jsjoeio commented Jul 13, 2021

I guess it might be? Maybe it's a bug? I went into the settings and added "Pre-Build" as a required check. Maybe it's sneaking in because the previous run had both of those passing? I'm not too sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants