-
Notifications
You must be signed in to change notification settings - Fork 5.9k
refactor: clean up testing files #3769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Ah, just curious, shouldn't the same formatting checks run on PRs and main? How'd it get merged in the first place? |
I hit enable auto-merge which says "Automatically merge when all requirements are met." - let me checking the repo settings |
Weird, pre-build is not required, but should be? Enabling now: cc @oxy and @code-asher |
actually, i bet i broke it when i changed it to "Pre-Build" instead of "Pre-build" |
argh, auto update imports didn't work lol fixing |
Haha, I dislike auto merge because of these sorts of problems, but I see how it can be helpful 🤷♂️ |
ac8790a
to
fc16f7e
Compare
I feel ya, luckily this has only happened once or twice |
Moment of truth |
Codecov Report
@@ Coverage Diff @@
## main #3769 +/- ##
==========================================
+ Coverage 61.55% 62.89% +1.33%
==========================================
Files 35 35
Lines 1813 1838 +25
Branches 365 371 +6
==========================================
+ Hits 1116 1156 +40
+ Misses 588 577 -11
+ Partials 109 105 -4
Continue to review full report at Codecov.
|
Hmm but we require both build and end-to-end tests which require pre-build? Is it sneaking in the auto-merge in the gaps before the next check starts?? |
I guess it might be? Maybe it's a bug? I went into the settings and added "Pre-Build" as a required check. Maybe it's sneaking in because the previous run had both of those passing? I'm not too sure |
I accidentally merged a PR that didn't have a file formatted correctly and it made CI on
main
fail. This fixes that but also clean ups some testing files to be better organized.