Skip to content

Removed files that are in .gitignore but still in the tree #380

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

MOZGIII
Copy link
Contributor

@MOZGIII MOZGIII commented Mar 29, 2019

Describe in detail the problem you had and how this PR fixes it

I'm doing the packing for debian, and I found out there are somes that are in the .gitignore (git clean -Xdf removes them) but they're in the tree. It cases some problems for the way I'm trying to package things.
Those files were probably added by mistake, so this PR removes them.

Is there an open issue you can link to?

Not that I'm aware of.

@code-asher
Copy link
Member

code-asher commented Mar 29, 2019

These are part of the requirefs tests and shouldn't be removed. We should probably un-ignore the lib folder there. We do that for lib/node_modules but not lib: https://github.com/codercom/code-server/blob/master/packages/requirefs/test/.gitignore#L1

We could also rename lib to something else. Maybe something like fixtures?

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Mar 29, 2019

I'm closing this PR then. At which level do you prefer them unignored?

@MOZGIII MOZGIII closed this Mar 29, 2019
@code-asher
Copy link
Member

code-asher commented Mar 29, 2019

I think it'd actually be better to rename the directory to fixtures.

@MOZGIII
Copy link
Contributor Author

MOZGIII commented Mar 29, 2019

Is the pattern in this repo to ignore all the lib dirs? Or maybe it should be /lib instead of lib at the top level?

@code-asher
Copy link
Member

Ah, that's a good point, we could just ignore /lib at the top level. That sounds good to me.

@MOZGIII MOZGIII deleted the gitignore-corrections branch April 1, 2019 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants