Skip to content

chore(ci): replace playwright gh action #3910

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 6, 2021

Conversation

greyscaled
Copy link
Contributor

This action is no longer needed, see README for the action here: https://github.com/microsoft/playwright-github-action#%EF%B8%8F-you-dont-need-this-github-action-%EF%B8%8F

The suggested way to install OS deps for playwright is simply:

npx playwright install-deps

Reference: https://playwright.dev/docs/ci/#github-actions

@greyscaled greyscaled requested a review from jsjoeio August 6, 2021 03:00
@greyscaled greyscaled self-assigned this Aug 6, 2021
@greyscaled greyscaled requested a review from a team as a code owner August 6, 2021 03:00
@greyscaled greyscaled requested a review from GirlBossRush August 6, 2021 03:01
@codecov
Copy link

codecov bot commented Aug 6, 2021

Codecov Report

Merging #3910 (3262cd8) into main (f75edc2) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #3910   +/-   ##
=======================================
  Coverage   63.51%   63.51%           
=======================================
  Files          36       36           
  Lines        1872     1872           
  Branches      379      379           
=======================================
  Hits         1189     1189           
  Misses        580      580           
  Partials      103      103           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f75edc2...3262cd8. Read the comment docs.

@greyscaled greyscaled enabled auto-merge (squash) August 6, 2021 03:24
@greyscaled greyscaled merged commit 7338037 into main Aug 6, 2021
Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beautiful! And it looks like all the e2e are still working! Thanks Grey 🙌

@greyscaled greyscaled deleted the vapurrmaid/replace-playwright-action branch August 6, 2021 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants