Push latest Docker tag along with version tag #4120
Conversation
Codecov Report
@@ Coverage Diff @@
## main #4120 +/- ##
=======================================
Coverage 64.12% 64.12%
=======================================
Files 36 36
Lines 1873 1873
Branches 379 379
=======================================
Hits 1201 1201
Misses 571 571
Partials 101 101 Continue to review full report at Codecov.
|
| tags = ["docker.io/codercom/code-server:${VERSION}"] | ||
| tags = [ | ||
| "docker.io/codercom/code-server:latest", | ||
| notequal("latest",VERSION) ? "docker.io/codercom/code-server:${VERSION}" : "", |
There was a problem hiding this comment.
Hmm, this doesn't seem like it'd work correctly in the case where we're trying to re-build an old version (not sure if we ever do that though) since latest would move "backwards"
Seems we'd need some way to check the "current" latest version and compare before we update the tag, to make that work correctly
I guess this seems like a decent enough solution 🤷♂️
There was a problem hiding this comment.
We might be covered by the check here, more as a side effect though and only for versions already uploaded:
We could add a check here to see if it is greater than the latest version available and only then add latest (through a second env var I think).
There was a problem hiding this comment.
fwiw this does bring us back to what we had before we switched to buildx (always push to latest)
There was a problem hiding this comment.
Fair enough, don't let me stand in your way! 🙈
There was a problem hiding this comment.
Made an issue: #4121 Thanks for the suggestion!
#3920 (comment)
https://docs.docker.com/engine/reference/commandline/buildx_bake/