feat: add test for get_nfpm_arch() #4194
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4194 +/- ##
=======================================
Coverage 64.22% 64.22%
=======================================
Files 36 36
Lines 1873 1873
Branches 379 379
=======================================
Hits 1203 1203
Misses 569 569
Partials 101 101 Continue to review full report at Codecov.
|
|
✨ Coder.com for PR #4194 deployed! It will be updated on every commit.
|
jsjoeio
changed the title
jsjoeio
force-pushed
the
jsjoeio-add-sh-test
branch
from
5a78300 to
6967c6f
Compare
|
I don't know why this is passing locally but failing in CI 🤔
|
|
We think it's because the runner doesn't have |
jsjoeio
force-pushed
the
jsjoeio-add-sh-test
branch
from
fbd1386 to
24708b3
Compare
jawnsy
approved these changes
Sep 17, 2021
jsjoeio
force-pushed
the
jsjoeio-add-sh-test
branch
from
24708b3 to
d06f6a8
Compare
jsjoeio
force-pushed
the
jsjoeio-add-sh-test
branch
from
d06f6a8 to
6a69248
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds tests for build-packages.sh, specifically
This PR introduces a new file called
build-lib.shwhich extracts theget_nfpm_arch()function out ofbuild-packages.shso that it can be unit tested. I did this because if yousource build-packages.shit runs themainfunction.With this new approach, we can move individual functions related to the build process into
build-lib.shand unit test them.The inspiration for this came from some recent rockiness with the 3.12.0 release and our interest in stabilizing the build and release pipeline.
Fixes N/A
Note: I would love if we could fully test all our scripts used in the build and release process. I also tossed around the idea of rewriting these scripts in JS/TS but that's a discussion for the future 😉