Skip to content

chore(deps): update dependency @types/ws to v8 #4243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 29, 2021
Merged

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Sep 25, 2021

WhiteSource Renovate

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
@types/ws ^7.2.6 -> ^8.0.0 age adoption passing confidence

Configuration

📅 Schedule: At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box.

This PR has been generated by WhiteSource Renovate. View repository job log here.

@renovate renovate bot requested a review from a team as a code owner September 25, 2021 13:39
@codecov
Copy link

codecov bot commented Sep 25, 2021

Codecov Report

Merging #4243 (a78ce97) into main (1b80244) will decrease coverage by 0.23%.
The diff coverage is n/a.

❗ Current head a78ce97 differs from pull request most recent head 328b864. Consider uploading reports for the commit 328b864 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4243      +/-   ##
==========================================
- Coverage   65.32%   65.09%   -0.24%     
==========================================
  Files          36       36              
  Lines        1883     1882       -1     
  Branches      380      380              
==========================================
- Hits         1230     1225       -5     
- Misses        555      559       +4     
  Partials       98       98              
Impacted Files Coverage Δ
src/node/util.ts 81.72% <0.00%> (-1.53%) ⬇️
src/node/cli.ts 80.99% <0.00%> (-0.49%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1b80244...328b864. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 25, 2021

✨ Coder.com for PR #4243 deployed! It will be updated on every commit.

@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 27, 2021

I feel like we've had this come up in the past but had an issue or reason we can't upgrade. Can you remember @code-asher?

@code-asher
Copy link
Member

code-asher commented Sep 27, 2021 via email

@jsjoeio jsjoeio self-assigned this Sep 27, 2021
@jsjoeio jsjoeio added chore Related to maintenance or clean up dependencies Pull requests that update a dependency file labels Sep 27, 2021
@jsjoeio
Copy link
Contributor

jsjoeio commented Sep 27, 2021

Dang, nice find! Okay, I'll fix the trivy issue then approve this

@jsjoeio jsjoeio enabled auto-merge September 29, 2021 22:11
@jsjoeio jsjoeio merged commit 6eda7ae into main Sep 29, 2021
@jsjoeio jsjoeio deleted the renovate/ws-8.x branch September 29, 2021 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Related to maintenance or clean up dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants