Skip to content

feat(cli): add test for readSocketPath #4275

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 7 commits into from
Closed

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Sep 29, 2021

This PR adds tests for readSocketPath.

TODOs

  • extract readSocketPath and export
  • fix TS error
  • write test for readSocketPath

Fixes N/A

@jsjoeio jsjoeio added the testing Anything related to testing label Sep 29, 2021
@jsjoeio jsjoeio self-assigned this Sep 29, 2021
@codecov
Copy link

codecov bot commented Sep 29, 2021

Codecov Report

Merging #4275 (e107a15) into main (6eda7ae) will decrease coverage by 4.30%.
The diff coverage is 57.14%.

❗ Current head e107a15 differs from pull request most recent head 87370ed. Consider uploading reports for the commit 87370ed to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4275      +/-   ##
==========================================
- Coverage   65.32%   61.01%   -4.31%     
==========================================
  Files          36       36              
  Lines        1883     1883              
  Branches      380      380              
==========================================
- Hits         1230     1149      -81     
- Misses        555      624      +69     
- Partials       98      110      +12     
Impacted Files Coverage Δ
src/node/cli.ts 50.20% <57.14%> (-31.28%) ⬇️
src/node/util.ts 80.71% <0.00%> (-2.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6eda7ae...87370ed. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Sep 29, 2021

✨ Coder.com for PR #4275 deployed! It will be updated on every commit.

@jsjoeio jsjoeio closed this Sep 30, 2021
@jsjoeio jsjoeio deleted the jsjoeio-add-test branch November 16, 2021 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant