feat: add tests for update.ts #4835
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
✨ Coder.com for PR #4835 deployed! It will be updated on every commit.
|
Codecov Report
@@ Coverage Diff @@
## main #4835 +/- ##
==========================================
+ Coverage 69.17% 69.72% +0.54%
==========================================
Files 29 29
Lines 1645 1645
Branches 363 363
==========================================
+ Hits 1138 1147 +9
+ Misses 430 424 -6
+ Partials 77 74 -3
Continue to review full report at Codecov.
|
code-asher
requested changes
Feb 8, 2022
|
bump @code-asher |
code-asher
approved these changes
Feb 11, 2022
jsjoeio
force-pushed
the
jsjoeio-update-test
branch
from
613093b to
99db1b7
Compare
code-asher
approved these changes
Feb 12, 2022
TinLe
pushed a commit
to TinLe/code-server
that referenced
this pull request
Apr 23, 2022
* feat: add isAddressInfo helper function * feat(update): add test for rejection UpdateProvider * feat: add more tests for UpdateProvider * fixup! move isAddressInfo, add .address check * fixup! remove extra writeHead * fixup! use -1 in redirect logic * fixup! remove unnecessary String call * fixup! use /latest for redirect * fixup! use match group for regex * fixup!: replace match/split logic
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more tests for
update.ts.Fixes #4831