Skip to content

testing: add new test for logLevels #4953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 7, 2022
Merged

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Mar 4, 2022

This adds a test to ensure that setting the log level with process.env.LOG_LEVEL to error sets it as expected.

Fixes #4916

@jsjoeio jsjoeio added the testing Anything related to testing label Mar 4, 2022
@jsjoeio jsjoeio self-assigned this Mar 4, 2022
@jsjoeio jsjoeio temporarily deployed to CI March 4, 2022 23:13 Inactive
@jsjoeio jsjoeio changed the title feat: add new test for logLevels testing: add new test for logLevels Mar 4, 2022
@codecov
Copy link

codecov bot commented Mar 4, 2022

Codecov Report

Merging #4953 (04b7239) into main (3c6f85c) will increase coverage by 0.23%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4953      +/-   ##
==========================================
+ Coverage   70.30%   70.54%   +0.23%     
==========================================
  Files          29       29              
  Lines        1677     1677              
  Branches      371      371              
==========================================
+ Hits         1179     1183       +4     
+ Misses        424      420       -4     
  Partials       74       74              
Impacted Files Coverage Δ
src/node/cli.ts 85.87% <0.00%> (+1.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c6f85c...04b7239. Read the comment docs.

@jsjoeio jsjoeio temporarily deployed to npm March 4, 2022 23:23 Inactive
@github-actions
Copy link

github-actions bot commented Mar 4, 2022

✨ Coder.com for PR #4953 deployed! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to CI March 7, 2022 21:54 Inactive
@jsjoeio jsjoeio marked this pull request as ready for review March 7, 2022 21:54
@jsjoeio jsjoeio requested a review from a team March 7, 2022 21:54
@jsjoeio jsjoeio temporarily deployed to npm March 7, 2022 22:03 Inactive
@jsjoeio jsjoeio merged commit 643ef13 into main Mar 7, 2022
@jsjoeio jsjoeio deleted the jsjoeio/add-loglevel-test branch March 7, 2022 23:08
TinLe pushed a commit to TinLe/code-server that referenced this pull request Apr 23, 2022
* feat: add new test for logLevels

* wip

* feat: add test for valid log level env var
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
testing Anything related to testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Testing]: write tests for logLevel in setDefaults
2 participants