Skip to content

feat(cli): support true for CS_DISABLE_FILE_DOWNLOADS #5134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 26, 2022

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Apr 26, 2022

After some feedback, we realized it is more intuitive to disable file
downloads by setting the environment variable
CS_DISABLE_FILE_DOWNLOADS to true than 1. This commit adds support
for both.

Fixes N/A

After some feedback, we realized it is more intuitive to disable file
downloads by setting the environment variable
`CS_DISABLE_FILE_DOWNLOADS` to `true` than `1`. This commit adds support
for both.
@jsjoeio jsjoeio added the enhancement Some improvement that isn't a feature label Apr 26, 2022
@jsjoeio jsjoeio added this to the April 2022 milestone Apr 26, 2022
@jsjoeio jsjoeio requested a review from a team April 26, 2022 19:40
@jsjoeio jsjoeio self-assigned this Apr 26, 2022
@github-actions
Copy link

github-actions bot commented Apr 26, 2022

✨ code-server docs for PR #5134 is ready! It will be updated on every commit.

@jsjoeio jsjoeio temporarily deployed to npm April 26, 2022 19:44 Inactive
@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #5134 (a9bdd37) into main (a0b3614) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a9bdd37 differs from pull request most recent head 8f1d6ac. Consider uploading reports for the commit 8f1d6ac to get more accurate results

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #5134   +/-   ##
=======================================
  Coverage   71.75%   71.75%           
=======================================
  Files          30       30           
  Lines        1685     1685           
  Branches      375      375           
=======================================
  Hits         1209     1209           
  Misses        407      407           
  Partials       69       69           
Impacted Files Coverage Δ
src/node/cli.ts 91.66% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a0b3614...8f1d6ac. Read the comment docs.

@github-actions
Copy link

github-actions bot commented Apr 26, 2022

✨ code-server dev build published to npm for PR #5134!

  • Last publish status: success
  • Commit: 8f1d6ac

To install in a local project, run:

npm install @coder/code-server-pr@5134

To install globally, run:

npm install -g @coder/code-server-pr@5134

@jsjoeio jsjoeio enabled auto-merge (squash) April 26, 2022 19:50
@jsjoeio jsjoeio temporarily deployed to npm April 26, 2022 19:55 Inactive
@jsjoeio jsjoeio merged commit e3c8bd6 into main Apr 26, 2022
@jsjoeio jsjoeio deleted the jsjoeio/update-download-logic branch April 26, 2022 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Some improvement that isn't a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants