Skip to content

chore: upgrade developmemt node version to v16 #5167

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2022
Merged

chore: upgrade developmemt node version to v16 #5167

merged 1 commit into from
May 6, 2022

Conversation

F3n67u
Copy link
Contributor

@F3n67u F3n67u commented May 6, 2022 •
edited
Loading

When using node v14, yarn will fail.

cd code-server/       
Using Node v14.19.1
➜  code-server git:(main) yarn
yarn install v1.22.15
[1/5] 🔍  Validating package.json...
error [email protected]: The engine "node" is incompatible with this module. Expected version "16". Got "14.19.1"
error Found incompatible module.
info Visit https://yarnpkg.com/en/docs/cli/install for documentation about this command.

@F3n67u F3n67u requested a review from a team May 6, 2022 09:00
code-asher
code-asher approved these changes May 6, 2022
View reviewed changes
Copy link
Member

@code-asher code-asher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find! Thanks.

@code-asher code-asher merged commit 66a3643 into coder:main May 6, 2022
@F3n67u F3n67u deleted the node16 branch May 6, 2022 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@code-asher code-asher code-asher approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@F3n67u @code-asher