Disable beforeUnload during app mode #584
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kylecarbs
requested changes
Apr 24, 2019
| e.preventDefault(); // FireFox | ||
| e.returnValue = ""; // Chrome | ||
| }); | ||
| if (!window.matchMedia("(display-mode: standalone)").matches) { |
There was a problem hiding this comment.
Won't match fullscreen. Is there a cleaner way to check if we're in a minified window mode?
https://developer.mozilla.org/en-US/docs/Web/CSS/@media/display-mode#Syntax
There was a problem hiding this comment.
The fullscreen mode would still have the problem where control + w closes the browser window, correct?
|
Obsoleted by GH-857. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe in detail the problem you had and how this PR fixes it
When code-server is running in app mode, the close window confirmation is annoying and unnecessary. This change prevents that behavior if in app mode.
Is there an open issue you can link to?
fixes #574