Skip to content

fix: parse port in path proxy #7337

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 2, 2025
Merged

fix: parse port in path proxy #7337

merged 1 commit into from
May 2, 2025

Conversation

kylecarbs
Copy link
Member

No description provided.

@kylecarbs kylecarbs requested a review from a team as a code owner May 2, 2025 16:11
@kylecarbs kylecarbs changed the title fix: parse part in path proxy fix: parse port in path proxy May 2, 2025
Copy link

codecov bot commented May 2, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.00%. Comparing base (4b7bca3) to head (65c8cd2).
Report is 23 commits behind head on main.

Files with missing lines Patch % Lines
src/node/routes/pathProxy.ts 75.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #7337      +/-   ##
==========================================
+ Coverage   72.94%   73.00%   +0.06%     
==========================================
  Files          29       29              
  Lines        1785     1793       +8     
  Branches      380      383       +3     
==========================================
+ Hits         1302     1309       +7     
- Misses        408      409       +1     
  Partials       75       75              
Files with missing lines Coverage Δ
src/node/routes/pathProxy.ts 87.50% <75.00%> (+5.35%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dded82b...65c8cd2. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@code-asher code-asher merged commit 47d6d3a into main May 2, 2025
11 checks passed
@code-asher code-asher deleted the parseport branch May 2, 2025 18:08
@code-asher
Copy link
Member

Ah wait does parseInt throw? I think it just returns NaN. Still technically fixes the original issue though 😆 so maybe I can just update it in the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants