Skip to content

Add workflow for bumping version #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 16 commits into from
Closed

Add workflow for bumping version #8

wants to merge 16 commits into from

Conversation

cmoog
Copy link
Contributor

@cmoog cmoog commented Dec 26, 2020

No description provided.

@cmoog cmoog requested a review from deansheather December 26, 2020 22:41
@cmoog
Copy link
Contributor Author

cmoog commented Dec 26, 2020

@deansheather my current thinking is that the cdr/coder-cli release workflow will invoke this workflow... but I'm not too happy with how that plan is shaping up.

@deansheather
Copy link
Member

Is there no way to do this from within the coder-cli release itself? Could just give coder-cli an SSH key with permission to do this stuff

@cmoog
Copy link
Contributor Author

cmoog commented Dec 26, 2020

Yes that is an option, we could move this workflow code to coder-cli. I do think the additional authentication complexity is a considerable downside to that approach though. I think we'd also need to create a PAT for gh

@deansheather
Copy link
Member

You'd still need code in coder-cli either way, so if you put the whole thing in coder-cli then you avoid having code in two places

@cmoog
Copy link
Contributor Author

cmoog commented Dec 27, 2020

The template living in a separate repo is arguably worse.

Copy link
Member

@deansheather deansheather left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

Comment on lines +22 to +31
./ci/scripts/gen-coder-cli-formula.sh ${{ github.event.inputs.version }}
git diff
git checkout -b bump-coder-cli-${{ github.event.inputs.version }}
git add coder-cli.rb
git commit -m "feat: bump coder-cli version to v${{ github.event.inputs.version }}"
git push --set-upstream origin bump-coder-cli-${{ github.event.inputs.version }}
gh pr create \
--title="bump coder-cli version to v${{ github.event.inputs.version }}" \
--body="" \
--reviewer cmoog
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Move this to a separate script file.

@cmoog
Copy link
Contributor Author

cmoog commented Mar 22, 2021

This has gotten a bit stale. Closing for now. We should first consider using something like https://github.com/goreleaser/goreleaser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants