Skip to content

flake: e2e externalAuth.spec.ts #356

Open
Open
@johnstcn

Description

@johnstcn

Problem

See #212 for context.

==> Errors
/home/runner/work/coder/coder/site/e2e/tests/externalAuth.spec.ts:15:
  13 | import { beforeCoderTest, resetExternalAuthKey } from "../hooks";
  14 |
> 15 | test.beforeAll(async ({ baseURL }) => {
     |      ^
  16 | 	const srv = await createServer(gitAuth.webPort);
  17 |
  18 | 	// The GitHub validate endpoint returns the currently authenticated user!
"beforeAll" hook timeout of 30000ms exceeded.

It looks like the hardcoded port (50516) can be unavailable for more than 30s.

Proposed Solution

  1. Simply bump the timeout (chore(site/e2e): increase timeout for waitForPort from 30s to 60s coder#16528)

  2. Refactor the e2e tests to dynamically create a port.

Metadata

Metadata

Assignees

Labels

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions