Skip to content

Revert "Revert "fix: Use SyscallConn for isTTY which is safe during f… #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 17, 2023
Merged

Revert "Revert "fix: Use SyscallConn for isTTY which is safe during f… #187

merged 1 commit into from
Aug 17, 2023

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Aug 17, 2023 •
edited
Loading

This reverts commit 5275fa7.

Closes #176

@coadler coadler requested a review from ammario August 17, 2023 20:40
@coadler coadler self-assigned this Aug 17, 2023
@coadler coadler merged commit b386d5d into main Aug 17, 2023
@coadler coadler deleted the colin/revert branch August 17, 2023 20:42
@coadler coadler mentioned this pull request Aug 17, 2023
Closed
@coveralls
Copy link

Pull Request Test Coverage Report for Build e13298f369f25fa61786d54fe546e602a88943b5-PR-187

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 11 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 96.688%
Files with Coverage Reduction New Missed Lines %
internal/entryhuman/entry.go 11 88.14%
Totals Coverage Status
Change from base Build 0830a57ace3f1d1bb73ef823630307bfe993a710: -0.2%
Covered Lines: 759
Relevant Lines: 785
💛 - Coveralls

@mafredri mafredri mentioned this pull request Aug 24, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ammario ammario ammario approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Race in isTTY?
3 participants
@coadler @coveralls @ammario