Skip to content

fix: Inject coder ssh configuration between comments #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Jan 27, 2023
Merged

fix: Inject coder ssh configuration between comments #48

merged 23 commits into from
Jan 27, 2023

Conversation

BrunoQuaresma
Copy link
Contributor

No description provided.

@BrunoQuaresma BrunoQuaresma self-assigned this Jan 25, 2023
@BrunoQuaresma BrunoQuaresma changed the title fix: Removes first matching Host block fix: Inject coder ssh configuration between comments Jan 25, 2023
@BrunoQuaresma
Copy link
Contributor Author

Closes #42

mafredri
mafredri reviewed Jan 26, 2023
View reviewed changes
mafredri
mafredri reviewed Jan 26, 2023
View reviewed changes
@BrunoQuaresma
Copy link
Contributor Author

@mafredri so just to think out loud the logic here:

  • Check if there are only one start and end block comment. If there is more than one, show a "bad format" error.
  • Check if the start block is placed previously than the end block. If not, show a "bad format" error.
  • Remove the text
  • Add the new config

Does it look right?

@mafredri
Copy link
Member

Does it look right?

Yup, that sounds perfect @BrunoQuaresma. 👍🏻

@BrunoQuaresma
Copy link
Contributor Author

I wanted to add some tests to the SSHConfig but I figure out the testing runner for this project needs some extra work so I decided to not do it on this PR.

mafredri
mafredri reviewed Jan 27, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Still had some pretty minor but probably important (for good user experience) nits.

mafredri
mafredri approved these changes Jan 27, 2023
View reviewed changes
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing the nits. Code looks good to me, but I haven't tested the extension so might be good to have another set of eyes on it.

kylecarbs
kylecarbs approved these changes Jan 27, 2023
View reviewed changes
@BrunoQuaresma BrunoQuaresma merged commit 89ec20b into main Jan 27, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-42 branch January 27, 2023 20:11
@code-asher code-asher mentioned this pull request Apr 8, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

@mafredri mafredri Awaiting requested review from mafredri

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@BrunoQuaresma @mafredri @kylecarbs