Skip to content

Replace rimraf with rmdir in postinstall #41

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 12, 2022
Merged

Replace rimraf with rmdir in postinstall #41

merged 1 commit into from
Jan 12, 2022

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jan 12, 2022

Otherwise when you install for production this errors since rimraf is a
development-only module.

For example: https://github.com/coder/code-server/runs/4796480313?check_suite_focus=true#step:8:148

Otherwise when you install for production this errors since rimraf is a
development-only module.
@code-asher code-asher requested a review from jsjoeio January 12, 2022 23:43
Copy link

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice fix!

@code-asher code-asher merged commit db0490f into coder:main Jan 12, 2022
@code-asher code-asher deleted the rimraf branch January 12, 2022 23:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants