Skip to content

Migrate state to new database name #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 3, 2022
Merged

Migrate state to new database name #50

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
37 changes: 27 additions & 10 deletions src/vs/platform/storage/browser/storageService.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,14 @@ export class BrowserStorageService extends AbstractStorageService {
}

private getId(scope: StorageScope): string {
return scope === StorageScope.GLOBAL ? 'global' : this.payload.id;
/**
* Add a unique ID based on the current path for per-workspace databases.
* This prevents workspaces on different machines that share the same domain
* and file path from colliding (since it does not appear IndexedDB can be
* scoped to a path) as long as they are hosted on different paths.
* @author coder
*/
return scope === StorageScope.GLOBAL ? 'global' : (this.payload.id + '-' + hash(location.pathname.toString().replace(/\/$/, "")).toString(16));
}

protected async doInitialize(): Promise<void> {
Expand Down Expand Up @@ -76,6 +83,24 @@ export class BrowserStorageService extends AbstractStorageService {
const firstWorkspaceOpen = this.workspaceStorage.getBoolean(IS_NEW_KEY);
if (firstWorkspaceOpen === undefined) {
this.workspaceStorage.set(IS_NEW_KEY, true);
/**
* Migrate the old database.
* @author coder
*/
let db: IIndexedDBStorageDatabase | undefined
try {
db = await IndexedDBStorageDatabase.create({ id: this.payload.id }, this.logService)
const items = await db.getItems()
for (const [key, value] of items) {
this.workspaceStorage.set(key, value);
}
} catch (error) {
this.logService.error(`[IndexedDB Storage ${this.payload.id}] migrate error: ${toErrorMessage(error)}`);
} finally {
if (db) {
db.close()
}
}
} else if (firstWorkspaceOpen) {
this.workspaceStorage.set(IS_NEW_KEY, false);
}
Expand Down Expand Up @@ -215,15 +240,7 @@ export class IndexedDBStorageDatabase extends Disposable implements IIndexedDBSt
) {
super();

/**
* Add a unique ID based on the current path. This prevents workspaces on
* different machines that share the same domain and file path from
* colliding (since it does not appear IndexedDB can be scoped to a path) as
* long as they are hosted on different paths.
* @author coder
*/
const windowId = hash(location.pathname.toString()).toString(16);
this.name = `${IndexedDBStorageDatabase.STORAGE_DATABASE_PREFIX}${windowId}-${options.id}`;
this.name = `${IndexedDBStorageDatabase.STORAGE_DATABASE_PREFIX}${options.id}`;
this.broadcastChannel = options.broadcastChanges && ('BroadcastChannel' in window) ? new BroadcastChannel(IndexedDBStorageDatabase.STORAGE_BROADCAST_CHANNEL) : undefined;

this.whenConnected = this.connect();
Expand Down