refactor(community): redesign

lib/groupher_server/accounts/delegates/collect_folder.ex

@@ -3,7 +3,7 @@ defmodule GroupherServer.Accounts.Delegate.CollectFolder do
   user collect folder related
   """
   import Ecto.Query, warn: false
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   alias Helper.Types, as: T
   alias Helper.QueryBuilder

lib/groupher_server/accounts/delegates/publish.ex

@@ -7,7 +7,7 @@ defmodule GroupherServer.Accounts.Delegate.Publish do
   # import Helper.ErrorCode
   import ShortMaps
 
-  import GroupherServer.CMS.Helper.Matcher
+  import GroupherServer.CMS.Helper.MatcherOld
 
   alias Helper.{ORM, QueryBuilder}
   # alias GroupherServer.{Accounts, Repo}

lib/groupher_server/accounts/delegates/upvoted_articles.ex

@@ -2,7 +2,6 @@ defmodule GroupherServer.Accounts.Delegate.UpvotedArticles do
   @moduledoc """
   get contents(posts, jobs ...) that user upvotes
   """
-  # import GroupherServer.CMS.Helper.Matcher
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1]
   import ShortMaps

lib/groupher_server/cms/cms.ex

@@ -31,6 +31,10 @@ defmodule GroupherServer.CMS do
   # see https://github.com/elixir-lang/elixir/issues/5306
 
   # Community CURD: editors, thread, tag
+  defdelegate read_community(args), to: CommunityCURD
+  defdelegate read_community(args, user), to: CommunityCURD
+  defdelegate create_community(args), to: CommunityCURD
+  defdelegate update_community(id, args), to: CommunityCURD
   # >> editor ..
   defdelegate update_editor(user, community, title), to: CommunityCURD
   # >> geo info ..
@@ -51,9 +55,6 @@ defmodule GroupherServer.CMS do
   defdelegate unset_article_tag(thread, article_id, tag_id), to: ArticleTag
   defdelegate paged_article_tags(filter), to: ArticleTag
 
-  defdelegate create_tag(community, thread, attrs, user), to: CommunityCURD
-  defdelegate update_tag(attrs), to: CommunityCURD
-
   # >> wiki & cheatsheet (sync with github)
   defdelegate get_wiki(community), to: CommunitySync
   defdelegate get_cheatsheet(community), to: CommunitySync
@@ -113,9 +114,6 @@ defmodule GroupherServer.CMS do
   defdelegate undo_pin_article(thread, id, community_id), to: ArticleCommunity
   defdelegate lock_article_comment(article), to: ArticleCommunity
 
-  # >> tag: set / unset
-  defdelegate set_tag(thread, tag, content_id), to: ArticleCommunity
-  defdelegate unset_tag(thread, tag, content_id), to: ArticleCommunity
   # >> community: set / unset
   defdelegate mirror_article(thread, article_id, community_id), to: ArticleCommunity
   defdelegate unmirror_article(thread, article_id, community_id), to: ArticleCommunity

lib/groupher_server/cms/community.ex

@@ -9,6 +9,7 @@ defmodule GroupherServer.CMS.Community do
   alias GroupherServer.{Accounts, CMS}
 
   alias CMS.{
+    Embeds,
     Category,
     CommunityThread,
     CommunitySubscriber,
@@ -35,13 +36,22 @@ defmodule GroupherServer.CMS.Community do
     field(:raw, :string)
     field(:index, :integer)
     field(:geo_info, :map)
+    field(:views, :integer)
 
+    embeds_one(:meta, Embeds.CommunityMeta, on_replace: :delete)
     belongs_to(:author, Accounts.User, foreign_key: :user_id)
 
     has_many(:threads, {"communities_threads", CommunityThread})
     has_many(:subscribers, {"communities_subscribers", CommunitySubscriber})
     has_many(:editors, {"communities_editors", CommunityEditor})
 
+    field(:articles_count, :integer, default: 0)
+    field(:editors_count, :integer, default: 0)
+    field(:subscribers_count, :integer, default: 0)
+
+    field(:viewer_has_subscribed, :boolean, default: false, virtual: true)
+    field(:viewer_is_editor, :boolean, default: false, virtual: true)
+
     has_one(:wiki, CommunityWiki)
     has_one(:cheatsheet, CommunityCheatsheet)
 
@@ -68,6 +78,7 @@ defmodule GroupherServer.CMS.Community do
     community
     |> cast(attrs, @optional_fields ++ @required_fields)
     |> validate_required(@required_fields)
+    |> cast_embed(:meta, with: &Embeds.CommunityMeta.changeset/2)
     |> validate_length(:title, min: 1, max: 30)
     |> foreign_key_constraint(:user_id)
     |> unique_constraint(:title, name: :communities_title_index)
@@ -82,6 +93,7 @@ defmodule GroupherServer.CMS.Community do
     # |> unique_constraint(:title, name: :communities_title_index)
     community
     |> cast(attrs, @optional_fields ++ @required_fields)
+    |> cast_embed(:meta, with: &Embeds.CommunityMeta.changeset/2)
     |> validate_length(:title, min: 1, max: 30)
     |> foreign_key_constraint(:user_id)
     |> unique_constraint(:title, name: :communities_title_index)

lib/groupher_server/cms/delegates/abuse_report.ex

@@ -5,7 +5,7 @@ defmodule GroupherServer.CMS.Delegate.AbuseReport do
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1, strip_struct: 1, get_config: 2]
 
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import ShortMaps
 
   alias Helper.ORM

lib/groupher_server/cms/delegates/article_collect.ex

@@ -2,7 +2,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCollect do
   @moduledoc """
   reaction[upvote, collect, watch ...] on article [post, job...]
   """
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1]
 

lib/groupher_server/cms/delegates/article_comment.ex

@@ -7,7 +7,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
   import Helper.ErrorCode
 
   import GroupherServer.CMS.Delegate.Helper, only: [mark_viewer_emotion_states: 3]
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import ShortMaps
 
   alias Helper.Types, as: T
@@ -106,7 +106,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
         add_participator_to_article(article, user)
       end)
       |> Repo.transaction()
-      |> upsert_comment_result()
+      |> result()
     end
   end
 
@@ -130,7 +130,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
       ORM.update(comment, %{body_html: @delete_hint, is_deleted: true})
     end)
     |> Repo.transaction()
-    |> upsert_comment_result()
+    |> result()
   end
 
   # add participator to article-like content (Post, Job ...) and update count
@@ -274,16 +274,16 @@ defmodule GroupherServer.CMS.Delegate.ArticleComment do
     Map.merge(paged_comments, %{entries: entries})
   end
 
-  defp upsert_comment_result({:ok, %{create_article_comment: result}}), do: {:ok, result}
-  defp upsert_comment_result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
+  defp result({:ok, %{create_article_comment: result}}), do: {:ok, result}
+  defp result({:ok, %{delete_article_comment: result}}), do: {:ok, result}
 
-  defp upsert_comment_result({:error, :create_article_comment, result, _steps}) do
+  defp result({:error, :create_article_comment, result, _steps}) do
     raise_error(:create_comment, result)
   end
 
-  defp upsert_comment_result({:error, :add_participator, result, _steps}) do
+  defp result({:error, :add_participator, result, _steps}) do
     {:error, result}
   end
 
-  defp upsert_comment_result({:error, _, result, _steps}), do: {:error, result}
+  defp result({:error, _, result, _steps}), do: {:error, result}
 end

lib/groupher_server/cms/delegates/article_comment_action.ex

@@ -9,7 +9,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommentAction do
   import GroupherServer.CMS.Delegate.ArticleComment,
     only: [add_participator_to_article: 2, do_create_comment: 4, update_article_comments_count: 2]
 
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   alias Helper.Types, as: T
   alias Helper.ORM

lib/groupher_server/cms/delegates/article_community.ex

@@ -3,12 +3,11 @@ defmodule GroupherServer.CMS.Delegate.ArticleCommunity do
   set / unset operations for Article-like resource
   """
   import GroupherServer.CMS.Helper.Matcher
-  import GroupherServer.CMS.Helper.Matcher2
   import Ecto.Query, warn: false
 
   import Helper.ErrorCode
   import Helper.Utils, only: [strip_struct: 1, done: 1]
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   alias Helper.Types, as: T
   alias Helper.ORM

lib/groupher_server/cms/delegates/article_curd.ex

@@ -4,7 +4,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   """
   import Ecto.Query, warn: false
 
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   import Helper.Utils,
     only: [done: 1, pick_by: 2, integerfy: 1, strip_struct: 1, module_to_thread: 1]
@@ -19,7 +19,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
   alias Accounts.User
   alias CMS.{Author, Community, PinnedArticle, Embeds, Delegate}
 
-  alias Delegate.{ArticleCommunity, ArticleTag}
+  alias Delegate.{ArticleCommunity, ArticleTag, CommunityCURD}
 
   alias Ecto.Multi
 
@@ -47,8 +47,19 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
       |> Multi.run(:add_viewed_user, fn _, %{inc_views: article} ->
         update_viewed_user_list(article, user_id)
       end)
+      |> Multi.run(:set_viewer_has_states, fn _, %{inc_views: article} ->
+        article_meta = if is_nil(article.meta), do: @default_article_meta, else: article.meta
+
+        viewer_has_states = %{
+          viewer_has_collected: user_id in article_meta.collected_user_ids,
+          viewer_has_upvoted: user_id in article_meta.upvoted_user_ids,
+          viewer_has_reported: user_id in article_meta.reported_user_ids
+        }
+
+        {:ok, Map.merge(article, viewer_has_states)}
+      end)
       |> Repo.transaction()
-      |> read_result()
+      |> result()
     end
   end
 
@@ -135,6 +146,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
       |> Multi.run(:set_article_tags, fn _, %{create_article: article} ->
         ArticleTag.set_article_tags(community, thread, article, attrs)
       end)
+      |> Multi.run(:update_community_article_count, fn _, _ ->
+        CommunityCURD.update_community_count_field(community, thread)
+      end)
       |> Multi.run(:mention_users, fn _, %{create_article: article} ->
         Delivery.mention_from_content(community.raw, thread, article, attrs, %User{id: uid})
         {:ok, :pass}
@@ -183,18 +197,42 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
       ArticleCommunity.update_edit_status(update_article)
     end)
     |> Repo.transaction()
-    |> update_article_result()
+    |> result()
   end
 
+  @doc """
+  mark delete falst for an anticle
+  """
   def mark_delete_article(thread, id) do
-    with {:ok, info} <- match(thread) do
-      ORM.find_update(info.model, %{id: id, mark_delete: true})
+    with {:ok, info} <- match(thread),
+         {:ok, article} <- ORM.find(info.model, id, preload: :communities) do
+      Multi.new()
+      |> Multi.run(:update_article, fn _, _ ->
+        ORM.update(article, %{mark_delete: true})
+      end)
+      |> Multi.run(:update_community_article_count, fn _, _ ->
+        CommunityCURD.update_community_count_field(article.communities, thread)
+      end)
+      |> Repo.transaction()
+      |> result()
     end
   end
 
+  @doc """
+  undo mark delete falst for an anticle
+  """
   def undo_mark_delete_article(thread, id) do
-    with {:ok, info} <- match(thread) do
-      ORM.find_update(info.model, %{id: id, mark_delete: false})
+    with {:ok, info} <- match(thread),
+         {:ok, article} <- ORM.find(info.model, id, preload: :communities) do
+      Multi.new()
+      |> Multi.run(:update_article, fn _, _ ->
+        ORM.update(article, %{mark_delete: false})
+      end)
+      |> Multi.run(:update_community_article_count, fn _, _ ->
+        CommunityCURD.update_community_count_field(article.communities, thread)
+      end)
+      |> Repo.transaction()
+      |> result()
     end
   end
 
@@ -406,12 +444,11 @@ defmodule GroupherServer.CMS.Delegate.ArticleCURD do
     end
   end
 
-  defp update_article_result({:ok, %{update_edit_status: result}}), do: {:ok, result}
-  defp update_article_result({:error, :update_article, result, _steps}), do: {:error, result}
-
-  defp read_result({:ok, %{inc_views: result}}), do: result |> done()
+  defp result({:ok, %{update_edit_status: result}}), do: {:ok, result}
+  defp result({:ok, %{update_article: result}}), do: {:ok, result}
+  defp result({:ok, %{set_viewer_has_states: result}}), do: result |> done()
 
-  defp read_result({:error, _, result, _steps}) do
+  defp result({:error, _, result, _steps}) do
     {:error, result}
   end
 end

lib/groupher_server/cms/delegates/article_emotion.ex

@@ -3,7 +3,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleEmotion do
   CURD and operations for article comments
   """
   import Ecto.Query, warn: false
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
 
   import GroupherServer.CMS.Delegate.Helper, only: [update_emotions_field: 4]
 

lib/groupher_server/cms/delegates/article_tag.ex

@@ -3,9 +3,9 @@ defmodule GroupherServer.CMS.Delegate.ArticleTag do
   community curd
   """
   import Ecto.Query, warn: false
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import Helper.Validator.Guards, only: [g_is_id: 1]
-  import Helper.Utils, only: [done: 1, camelize_map_key: 2, map_atom_values_to_upcase_str: 1]
+  import Helper.Utils, only: [done: 1, map_atom_values_to_upcase_str: 1]
   import GroupherServer.CMS.Delegate.ArticleCURD, only: [ensure_author_exists: 1]
   import ShortMaps
   import Helper.ErrorCode

lib/groupher_server/cms/delegates/article_upvote.ex

@@ -2,7 +2,7 @@ defmodule GroupherServer.CMS.Delegate.ArticleUpvote do
   @moduledoc """
   reaction[upvote, collect, watch ...] on article [post, job...]
   """
-  import GroupherServer.CMS.Helper.Matcher2
+  import GroupherServer.CMS.Helper.Matcher
   import Ecto.Query, warn: false
   import Helper.Utils, only: [done: 1]
 

lib/groupher_server/cms/delegates/comment_curd.ex

@@ -6,7 +6,7 @@ defmodule GroupherServer.CMS.Delegate.CommentCURD do
   import Helper.Utils, only: [done: 1]
   import Helper.ErrorCode
 
-  import GroupherServer.CMS.Helper.Matcher
+  import GroupherServer.CMS.Helper.MatcherOld
   import ShortMaps
 
   alias Helper.{ORM, QueryBuilder}