Skip to content

ScalaJs 1.0.0-M1 support #33

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 11, 2017
Merged

ScalaJs 1.0.0-M1 support #33

merged 1 commit into from
Jul 11, 2017

Conversation

andreaTP
Copy link
Contributor

@andreaTP andreaTP commented Jul 3, 2017

No description provided.

@andreaTP andreaTP force-pushed the sjs1.0.0-M1 branch 2 times, most recently from 3cfb9fd to 0ec08fa Compare July 3, 2017 16:03
@olafurpg
Copy link
Collaborator

olafurpg commented Jul 8, 2017

Hi @andreaTP 😄 Thank you for this contribution! Could you please rebase on top of master to resolve the build conflicts introduced by #34?

@andreaTP
Copy link
Contributor Author

Hi @olafurpg please double check this!

olafurpg
olafurpg approved these changes Jul 11, 2017
View reviewed changes
Copy link
Collaborator

@olafurpg olafurpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-checked locally, LGTM 👍 Although it's a shame that we have to exit sbt to cross-build sjs.

The sourcecode built matrix will soon grow larger than the library sources!
screen shot 2017-07-11 at 09 04 37

@olafurpg olafurpg merged commit f23effa into com-lihaoyi:master Jul 11, 2017
@olafurpg
Copy link
Collaborator

sourcecode 0.1.4 for sjs 1.0.0-M1 is its way to maven central.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olafurpg olafurpg olafurpg approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andreaTP @olafurpg