Skip to content

ci(mypy): redo #1480 #1509

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

bearomorphism
Copy link
Contributor

@bearomorphism bearomorphism commented Jun 8, 2025

Description

#1466 accidentally reverted the changes in #1480. This PR is fixing that.

Checklist

Copy link

codecov bot commented Jun 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (refactors@baee83e). Learn more about missing BASE report.

Additional details and impacted files
@@             Coverage Diff              @@
##             refactors    #1509   +/-   ##
============================================
  Coverage             ?   97.82%           
============================================
  Files                ?       57           
  Lines                ?     2618           
  Branches             ?        0           
============================================
  Hits                 ?     2561           
  Misses               ?       57           
  Partials             ?        0           
Flag Coverage Δ
unittests 97.82% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@bearomorphism bearomorphism mentioned this pull request Jun 8, 2025
10 tasks
@bearomorphism bearomorphism changed the title ci(mypy): fix linter error ci(mypy): redo #1480 Jun 8, 2025
@bearomorphism
Copy link
Contributor Author

Mentioned the issue in #1457 (comment)

@Lee-W I think we don't need to merge this if you can revert the force-push

@bearomorphism bearomorphism marked this pull request as draft June 8, 2025 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants