chore(security): fixed 5 vulnerabilities #599
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for doing this. It looks good except that on Windows the builds are breaking which is the same we were seeing when attempting this upgrade. |
|
@jimthedev Have you found out why it was breaking? |
Berkmann18
changed the title
Berkmann18
changed the title
|
Looks like it was the windows builds. Something like Cmd.exe existed with code 1 but then I didn't catch the actual error and the build is gone now. If you rebase it should happen again. |
Fixed 5 vulnerabilities found in `semantic-release`.
Rebased from the master branch an fixed additional vulnerabilities
jimthedev
approved these changes
Jul 17, 2019
|
🎉 This PR is included in version 3.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed 5 (out of 13) vulnerabilities, all of which were caused by the
semantic-release's version used prior to this PR.The 8 others are caused by
codecovwhich are all only affecting the development so I left that aside (unless someone wants me to go ahead and try to fix those too).Also, after running a dependency check (with
npm-check -u), I've noticed that there were the following non-breaking updates which I think would be a good idea to do:fs-extra,inquirer,nodemon[dev]@babel/cli,@babel/core,@babel/preset-env,chai,eslint,nycandsemver.