-
Notifications
You must be signed in to change notification settings - Fork 555
Recreate the commitizen logo in png & svg format #878
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Awesome! What is the use case for adding so many different sizes of the same image? Binary files are not great to put in Git because every version of the file gets stored forever and needs to be downloaded every time you |
@LinusU Already on it - should have a commit addressing that shortly... |
@bromso I narrowed down the generated sizes according to some very hasty online research. I added 16x16 for the VSCode icon use case, then: 48, 96, 256, 512, 1024. Adding more sizes is trivial, (see line 24 in @LinusU I wanted to set up the Azure pipeline to generate them as build artifacts but not sure if I did that correctly (still learning this tech stack). I avoided using |
@dmwelch It all sounds good to me. As long as you guys are happy, I'm happy! 😄 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! 👍
🎉 This PR is included in version 4.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
No description provided.