-
Notifications
You must be signed in to change notification settings - Fork 36
XAssist - add model freedom and ollama support #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The failing CI (installing mamba/ micromamba) is due to the new release
Let's do this for now, untill the issue is fixed |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #156 +/- ##
==========================================
- Coverage 81.97% 75.26% -6.71%
==========================================
Files 19 19
Lines 760 837 +77
Branches 79 91 +12
==========================================
+ Hits 623 630 +7
- Misses 137 207 +70
|
std::cerr << "Failed to open file for reading URL for model " << model << std::endl; | ||
return ""; | ||
} | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Technically any utility function like these should be tested for (either in test_interpreter.cpp itself or maybe through a test_utils.cpp if possible)
But that can be done through subsequent PRs (an issue can be opened to track the same) !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clang-tidy reviews should be addressed. Apart from that it LGTM.
I would just wait for the green flag by @vgvassilev before merging !
1de9a78
to
e28d80a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's ignore the infrastructure issue of the clang-tidy bot.
Description
Type of change
Please tick all options which are relevant.