-
Notifications
You must be signed in to change notification settings - Fork 36
Enable support for multiple kernels for xeus-cpp-lite #290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 82.00% 81.78% -0.22%
==========================================
Files 20 20
Lines 950 950
Branches 87 87
==========================================
- Hits 779 777 -2
- Misses 171 173 +2
🚀 New features to boost your workflow:
|
clang-tidy review says "All clean, LGTM! 👍" |
Screen.Recording.2025-04-17.at.1.47.31.PM.mp4Demo above : Shows 3 xeus-cpp-lite kernels built (all use different flags -std=c++17/20/23) On top of which xcpp20 is built using the -msimd128 flag (required for running simd code in the browser)
So xcpp20 kernel would work but xcpp23 wouldn't ! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
dbf3ed8
to
b782277
Compare
clang-format is a bit too much (probably can be ignored here ?) |
Hey @JohanMabille @martinRenou As y'all helped me with the design here on the JupyterLite, could y'all review the changes here for me ?
So currently xeus-cpp-lite doesn't have exception handling due to missing emscripten flags.
And support this as I tried building on main |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really cool to finally get multiple kernel specs support in JupyterLite!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
clang-tidy made some suggestions
Description
Fixes #185
Type of change
Please tick all options which are relevant.