Skip to content

Add smallpt licence to example #304

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

mcbarton
Copy link
Collaborator

Description

Please include a summary of changes, motivation and context for this PR.

When the smallpt example was added to this repo, it was added without its licence, which clearly states that where it is included, it should contain the copyright notice and this permission notice. The original licence for this software was found here https://github.com/wedusk101/smallpt/blob/master/LICENSE.txt

Fixes # (issue)

Type of change

Please tick all options which are relevant.

  • Bug fix
  • New feature
  • Added/removed dependencies
  • Required documentation updates

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.78%. Comparing base (98585e8) to head (e74181a).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #304   +/-   ##
=======================================
  Coverage   81.78%   81.78%           
=======================================
  Files          20       20           
  Lines         950      950           
  Branches       87       87           
=======================================
  Hits          777      777           
  Misses        173      173           
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@mcbarton mcbarton requested a review from SylvainCorlay May 22, 2025 12:17
@anutosh491
Copy link
Collaborator

anutosh491 commented May 22, 2025

Hey @mcbarton, its just a bunch of comments and I know our deployment fails for now running smallpt. But we could take this in, if you could confirm things working with a local build. Let us know if that works !

@SylvainCorlay SylvainCorlay merged commit c8b9cd0 into compiler-research:main May 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants