-
Notifications
You must be signed in to change notification settings - Fork 931
fix(load): resolve plugins from extended configs #1976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
escapedcat
merged 6 commits into
conventional-changelog:master
from
juliuscc:fix/resolve-plugins-from-extends
Jun 29, 2020
Merged
Changes from 5 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
1cc4755
test(load): adds test for loading plugins from an extended config
a756934
fix(load): loads plugins from extended configs
8b42bc3
refactor: clean up a loading test
54869ea
test(load): adds test for including a shareable config with a local p…
592d265
test: adds more realistic test-scenarios
juliuscc ad3aecb
Update @commitlint/load/src/load.ts
juliuscc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
3 changes: 3 additions & 0 deletions
3
@commitlint/load/fixtures/extends-with-local-plugins/commitlint.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
extends: ['./config-with-local-plugin'], | ||
}; |
21 changes: 21 additions & 0 deletions
21
...nt/load/fixtures/extends-with-local-plugins/config-with-local-plugin/commitlint.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
module.exports = { | ||
extends: [], | ||
plugins: [{ | ||
rules: { | ||
'hello-world-rule': ({ subject }) => { | ||
const HELLO_WORLD = 'Hello World'; | ||
return [ | ||
subject.includes(HELLO_WORLD), | ||
`Your subject should contain ${HELLO_WORLD} message` | ||
]; | ||
}, | ||
'is-positive': ({ subject }) => { | ||
const POSITIVE_EMOJI = ':)'; | ||
return [ | ||
subject.includes(POSITIVE_EMOJI), | ||
`Your subject should contain ${POSITIVE_EMOJI} message` | ||
]; | ||
} | ||
} | ||
}] | ||
}; |
1 change: 1 addition & 0 deletions
1
@commitlint/load/fixtures/extends-with-local-plugins/config-with-local-plugin/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports = require('./commitlint.config.js'); |
3 changes: 3 additions & 0 deletions
3
@commitlint/load/fixtures/extends-with-plugins/commitlint.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
extends: ['./config-with-plugins'], | ||
}; |
3 changes: 3 additions & 0 deletions
3
@commitlint/load/fixtures/extends-with-plugins/config-with-plugins/commitlint.config.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,3 @@ | ||
module.exports = { | ||
plugins: ['example', '@scope/example'] | ||
}; |
1 change: 1 addition & 0 deletions
1
@commitlint/load/fixtures/extends-with-plugins/config-with-plugins/index.js
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
module.exports = require('./commitlint.config.js'); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.