mantle: openstack: fix passing of openstack config file path #1840
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miabbott
reviewed
Nov 9, 2020
|
one nit, but otherwise makes sense /approve |
This is a followup to b5eb5d6. We need to set $OS_CLIENT_CONFIG_FILE to the value given by the user, which is the path to the clouds.yaml on their local system.
dustymabe
force-pushed
the
dusty-fix-openstack-config-file
branch
from
71f8df9 to
a987e8f
Compare
jlebon
reviewed
Nov 9, 2020
|
/lgtm |
jlebon
pushed a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 9, 2020
We need to tell the OpenStack bindings where to find the user-provided `clouds.yaml` file. Do this using the `YAMLOpts` field of the `ClientOpts`. See also discussions in coreos#1840.
jlebon
added a commit
to jlebon/coreos-assembler
that referenced
this pull request
Nov 9, 2020
We need to tell the OpenStack bindings where to find the user-provided `clouds.yaml` file. Do this using the `YAMLOpts` field of the `ClientOpts`. See also discussions in coreos#1840.
|
/lgtm |
We need to tell the OpenStack bindings where to find the user-provided `clouds.yaml` file. Do this using the `YAMLOpts` field of the `ClientOpts`. See also discussions in coreos#1840.
This will add some context so a user might know where to look on why this was done and how it works.
dustymabe
force-pushed
the
dusty-fix-openstack-config-file
branch
from
1c465bd to
18da7cf
Compare
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dustymabe, jlebon, miabbott The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
openshift-merge-robot
pushed a commit
that referenced
this pull request
Nov 9, 2020
We need to tell the OpenStack bindings where to find the user-provided `clouds.yaml` file. Do this using the `YAMLOpts` field of the `ClientOpts`. See also discussions in #1840.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to b5eb5d6. We need to set $OS_CLIENT_CONFIG_FILE
to the value given by the user, which is the path to the clouds.yaml
on their local system.