NPU add titan test #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shink
reviewed
Apr 28, 2025
| uses: ./.github/workflows/_ascend_npu_torchtitan.yml | ||
| with: | ||
| runner: "linux-arm64-npu-2" | ||
| image: ${{ needs.prepare.outputs.image }} |
There was a problem hiding this comment.
Use ascendai/cann:8.0.0.beta1-910b-ubuntu22.04-py3.10 temporarily
shink
reviewed
May 30, 2025
Comment on lines
-154
to
-138
| benchmark: | ||
| name: Run benchmarks |
shink
reviewed
May 30, 2025
|
|
||
| jobs: | ||
| setup_environment: | ||
| name: Run Torchtitan Environment |
There was a problem hiding this comment.
Suggested change
| name: Run Torchtitan Environment | |
| name: run torchtitan tests |
shink
reviewed
May 30, 2025
Comment on lines
115
to
117
| - name: Install nightly torchvision and torchaudio | ||
| run: | | ||
| pip install --pre torchvision torchaudio --no-deps --index-url https://download.pytorch.org/whl/nightly/cpu |
There was a problem hiding this comment.
There is no need to install these two
shink
reviewed
May 30, 2025
Comment on lines
132
to
137
| - name: Run torchtitan integration_test | ||
| working-directory: torchtitan | ||
| run: | | ||
| mkdir artifacts-to-be-uploaded | ||
| npu_count=$(python -c "import torch; print(torch.npu.device_count())") | ||
| python ./tests/integration_tests.py artifacts-to-be-uploaded --ngpu ${npu_count} |
There was a problem hiding this comment.
Sounds good. And should we upload this dir artifacts-to-be-uploaded?
|
Please rebase your branch after #60 landed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.