Added the bindings for the Worktree API #1
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wtrep
requested review from
dblanchette,
dlevesque-coveo,
dotboris,
jonapich and
pballandras
fix bindings updated doc added tests not sure why I ignored that error need to lock before calling unlock
wtrep
force-pushed
the
feature/DT-5224-worktree-api
branch
from
571f9c2 to
bdf5a6f
Compare
|
👀 👀 👀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds bindings for interacting with the libgit2 Worktree API (https://libgit2.org/libgit2/#v1.5.0/group/worktree).
Some constructs are weird, but are similar to the rest of the repo (like the populateAddWorktreeOptions which init the struct but sometime returns nil). All the "populate" are the same so I preferred being consistant with the rest of the codebase.
I ran the tests as well.