[fs.class.directory.entry.general] Remove unneeded "unneeded" #7245
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
frederick-vs-ja
force-pushed
the
unneeded-unneeded
branch
from
bd0eb67 to
5b0921f
Compare
per @Quuxplusone's suggestion It is a bit tautological to say "unneeded call" in a note, because implementations should always prevent unneeded calls. Co-authored-by: Arthur O'Dwyer <[email protected]>
frederick-vs-ja
force-pushed
the
unneeded-unneeded
branch
from
5b0921f to
ac6a894
Compare
CaseyCarter
approved these changes
Aug 30, 2024
jwakely
approved these changes
Aug 30, 2024
jensmaurer
approved these changes
Aug 30, 2024
|
More to the point, it's redundant to say that an implementation may omit "unneeded" calls, because obviously an implementation must never omit a call of the other kind! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is a bit tautological to say "unneeded call" in a note, because implementations should always prevent unneeded calls.