fix superbuild cmake < 3.17 #193
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey thanks for the PR! Yeah, the version fallback seems like a good approach. I wonder if we should also |
|
For If I notice anything strange while continuing my project I will bring up the problem anyway. |
TheLartians
approved these changes
Feb 7, 2021
|
Fix is live in v0.28.3! 🎉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
issue: #192
CPM_INDENT (first commit) :
I agree with you. set(CPM_INDENT "CPM:" CACHE INTERNAL "") seems to be appropriate.
include(FetchContent):
Since the problem only occurs when using cmake < 3.17, I suggest to check the current cmake version and call
include(FetchContent)for eachinclude(CPM.cmake)when necessary.During a future upgrade of the minimal cmake version, this can be noticed and removed easily.