Skip to content

fix: disable Zend Signals and enable Zend Max Execution Timers for ZTS builds #135

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 21, 2023

Conversation

dunglas
Copy link
Contributor

@dunglas dunglas commented Aug 21, 2023

  • Zend Signals are known to be currently broken with ZTS builds, they should be disabled
  • The new Zend Max Execution Timers feature (specially designed for ZTS) fixes timeout support when using ZTS. It is enabled by default for ZTS build starting with PHP 8.3, but must be enabled manually for 8.1+ to preserve ABI compatibility, which isn't an issue here because we're creating a static build.

Related PHP issues:

The official ZTS Docker images also include these flags.

@crazywhalecc crazywhalecc added the bug Something isn't working label Aug 21, 2023
@crazywhalecc crazywhalecc added kind/php-and-sapi Issues related to php source and SAPI need test This PR has not been tested yet, cannot merge now labels Aug 21, 2023
Copy link
Owner

@crazywhalecc crazywhalecc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know much about ZTS bugs, but based on the information you provided, we need to disable the zend signal, and there is no better solution.

And --enable-zend-max-execution-timers makes ZTS safer.

Am I right?

@dunglas
Copy link
Contributor Author

dunglas commented Aug 21, 2023

Exactly.

@crazywhalecc crazywhalecc merged commit f4327c8 into crazywhalecc:main Aug 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working kind/php-and-sapi Issues related to php source and SAPI need test This PR has not been tested yet, cannot merge now
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants