Fix with_comment format in annotate_models_rake #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* :with_comment option is flag * It should use `true?` instead of `fallback`.
|
@ctran I would appreciate it if you could please review this patch. |
|
@ctran When is it going to release the new version which includes this patch? Now it's so inconvenient for our team. Please ship new version up if you have time 🙏 |
|
@yhirano55 it's published - https://rubygems.org/gems/annotate/versions/2.7.4 |
|
Thank you so much! |
mgpnd
pushed a commit
to mgpnd/annotate_models
that referenced
this pull request
Feb 15, 2019
* :with_comment option is flag * It should use `true?` instead of `fallback`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
true?instead offallback.Now with_comment option is enforcely overwritten in annotate_models.rake. So I've fixed it.